From: Thomas Graf <tgraf@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, shemminger@vyatta.com,
jesse.brandeburg@gmail.com, hawk@diku.dk, netdev@vger.kernel.org
Subject: Re: [RFC] skb align patch
Date: Wed, 23 Sep 2009 01:47:48 -0400 [thread overview]
Message-ID: <20090923054748.GA24045@bombadil.infradead.org> (raw)
In-Reply-To: <20090921.222940.258576265.davem@davemloft.net>
On Mon, Sep 21, 2009 at 10:29:40PM -0700, David Miller wrote:
> The alignment in this patch is a real big deal for 64 byte forwarding
> tests, where the entire packet is a whole PCI-E cacheline. But not
> if it isn't aligned properly.
As I pointed out to Herbert already, this alignment change may actually
make things worse or even break things as long as compare_ether_header()
used in __napi_gro_receive() expects the IP header to be aligned to 4
bytes. That can be fixed of course, just wanted to mention it.
next prev parent reply other threads:[~2009-09-23 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-20 21:22 [RFC] skb align patch Stephen Hemminger
2009-09-21 6:13 ` Eric Dumazet
2009-09-22 4:30 ` Stephen Hemminger
2009-09-22 3:20 ` Eric Dumazet
2009-09-22 5:23 ` Stephen Hemminger
2009-09-22 5:29 ` David Miller
2009-09-23 5:47 ` Thomas Graf [this message]
2009-09-25 22:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923054748.GA24045@bombadil.infradead.org \
--to=tgraf@infradead.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hawk@diku.dk \
--cc=jesse.brandeburg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).