netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: David.Choi@Micrel.Com
Cc: greg@kroah.com, netdev@vger.kernel.org, Charles.Li@Micrel.Com,
	Choi@kroah.com, jgarzik@redhat.com, shemminger@vyatta.com
Subject: Re: [PATCH] drivers/net: ks8851 ethernet network driver - RESUBMIT
Date: Fri, 25 Sep 2009 12:09:47 -0700 (PDT)	[thread overview]
Message-ID: <20090925.120947.24952563.davem@davemloft.net> (raw)
In-Reply-To: <C43529A246480145B0A6D0234BDB0F0D02127E@MELANITE.micrel.com>


This patch does not apply.

There is already a CONFIG_KS8851 and a drivers/net/ks8851.c driver
in Linus's tree right now.  So it completely conflicts with your's

I'm getting burnt out going back and forth trying to apply this
patch and it doesn't apply cleanly or there's already a driver
with that name etc.

This is a complete mess and a very poor driver submission.

Please get things straight, look at how other developers write
their commit messages and signoffs (your's was in bad style and
the signoff was not in the format described in
linux/Documentation/SubmittingPatches, for example).

  reply	other threads:[~2009-09-25 19:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  2:38 [PATCH] ks8851_ml ethernet network driver Greg KH
2009-09-17  3:48 ` David Miller
2009-09-17 13:03   ` Greg KH
2009-09-17 19:06   ` Choi, David
2009-09-17 19:30   ` Choi, David
2009-09-17 23:49     ` David Miller
2009-09-18  5:27       ` Greg KH
2009-09-24 23:02       ` [PATCH] ks8851_ml ethernet network driver - FIXED LINE-WRAPPING ISSUE Choi, David
2009-09-24 23:39         ` David Miller
2009-09-25 17:58           ` [PATCH] drivers/net: ks8851 ethernet network driver - RESUBMIT Choi, David
2009-09-25 19:09             ` David Miller [this message]
2009-09-26  0:42               ` [PATCH 2.6.31-rc9] drivers/net: ks8851_mll ethernet network driver Choi, David
2009-10-01  3:05                 ` David Miller
2009-10-01 14:51                   ` Choi, David
2009-09-17  4:03 ` [PATCH] ks8851_ml " Stephen Hemminger
2009-09-17 19:11   ` Choi, David
2009-09-17  4:07 ` Stephen Hemminger
2009-09-17 19:20   ` Choi, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090925.120947.24952563.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Charles.Li@Micrel.Com \
    --cc=Choi@kroah.com \
    --cc=David.Choi@Micrel.Com \
    --cc=greg@kroah.com \
    --cc=jgarzik@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).