From: Jiri Pirko <jpirko@redhat.com>
To: Bill Fink <billfink@mindspring.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
netdev@vger.kernel.org, davem@davemloft.net,
bonding-devel@lists.sourceforge.net, nicolas.2p.debian@free.fr
Subject: Re: [PATCH net-next-2.6 v2] bonding: introduce primary_reselect option
Date: Fri, 25 Sep 2009 15:25:19 +0200 [thread overview]
Message-ID: <20090925132518.GA3657@psychotron.redhat.com> (raw)
In-Reply-To: <20090925034725.60bcd85b.billfink@mindspring.com>
Fri, Sep 25, 2009 at 09:47:25AM CEST, billfink@mindspring.com wrote:
>On Thu, 24 Sep 2009, Jay Vosburgh wrote:
>
>>
>> From: Jiri Pirko <jpirko@redhat.com>
>>
>> In some cases there is not desirable to switch back to primary interface when
>> it's link recovers and rather stay with currently active one. We need to avoid
>> packetloss as much as we can in some cases. This is solved by introducing
>> primary_reselect option. Note that enslaved primary slave is set as current
>> active no matter what.
>>
>> Patch modified by Jay Vosburgh as follows: fixed bug in action
>> after change of option setting via sysfs, revised the documentation
>> update, and bumped the bonding version number.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>> ---
>>
>> Note that this patch depends on the "make ab_arp select active
>> slaves as other modes" patch recently approved, but not yet appearing in
>> net-next-2.6 as I write this. http://patchwork.ozlabs.org/patch/32684/
>>
>> Documentation/networking/bonding.txt | 42 +++++++++++++++++++++-
>> drivers/net/bonding/bond_main.c | 66 +++++++++++++++++++++++++++++++---
>> drivers/net/bonding/bond_main.c.rej | 18 +++++++++
>> drivers/net/bonding/bond_sysfs.c | 53 +++++++++++++++++++++++++++
>> drivers/net/bonding/bonding.h | 11 +++++-
>> 5 files changed, 182 insertions(+), 8 deletions(-)
>> create mode 100644 drivers/net/bonding/bond_main.c.rej
>
>I doubt you intended to include a patch reject file in your patch.
Noticed - I'm about to resend...
>
> -Bill
next prev parent reply other threads:[~2009-09-25 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 19:53 [PATCH net-next-2.6 v2] bonding: introduce primary_reselect option Jiri Pirko
2009-09-25 0:34 ` Jay Vosburgh
2009-09-25 7:47 ` Bill Fink
2009-09-25 13:25 ` Jiri Pirko [this message]
2009-09-25 14:32 ` Jay Vosburgh
2009-09-25 13:28 ` Jiri Pirko
2009-10-07 8:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090925132518.GA3657@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=billfink@mindspring.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).