From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: David Miller <davem@davemloft.net>
Cc: avorontsov@ru.mvista.com, linux-pm@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] 3c59x: Get rid of "Trying to free already-free IRQ"
Date: Fri, 25 Sep 2009 14:35:24 +0200 [thread overview]
Message-ID: <200909251435.24942.rjw@sisk.pl> (raw)
In-Reply-To: <20090924.152619.260814858.davem@davemloft.net>
On Friday 25 September 2009, David Miller wrote:
> From: Anton Vorontsov <avorontsov@ru.mvista.com>
> Date: Fri, 25 Sep 2009 01:30:39 +0400
>
> > On Thu, Sep 24, 2009 at 10:30:33PM +0200, Rafael J. Wysocki wrote:
> >> On Thursday 24 September 2009, Anton Vorontsov wrote:
> >> > Following trace pops up if we try to suspend with 3c59x ethernet NIC
> >> > brought down:
> >>
> >> Patch looks good, but IMO it'd be a little effort to convert the driver to
> >> dev_pm_ops while you're at it (please see r8169 for a working example).
> >
> > I'd like to avoid putting irrelevant stuff into bugfixes.
>
> Agreed.
Well, the point is that all of the PCI core stuff the driver does is not
necessary and should better be dropped along with the IRQ thing.
Best,
Rafael
next prev parent reply other threads:[~2009-09-25 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 18:31 [PATCH] 3c59x: Get rid of "Trying to free already-free IRQ" Anton Vorontsov
2009-09-24 20:30 ` Rafael J. Wysocki
2009-09-24 21:30 ` Anton Vorontsov
2009-09-24 22:26 ` David Miller
2009-09-25 12:35 ` Rafael J. Wysocki [this message]
2009-09-24 22:47 ` David Miller
2009-09-25 4:43 ` [linux-pm] " Alan Stern
2009-09-25 12:32 ` Rafael J. Wysocki
2009-09-25 12:56 ` Anton Vorontsov
2009-09-25 13:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909251435.24942.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).