From: Denys Fedoryschenko <denys@visp.net.lb>
To: David Dillow <dave@thedillows.org>
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: r8169, enabling TX checksumming breaks things?
Date: Sat, 26 Sep 2009 02:18:54 +0300 [thread overview]
Message-ID: <200909260218.54899.denys@visp.net.lb> (raw)
In-Reply-To: <1253754752.13176.19.camel@obelisk.thedillows.org>
>
> This is the patch I have against HEAD, which Works For Me (TM). If I
> recall correctly the list in rtl8169_set_tso_csum() is from combing the
> vendor drivers, but I'm not 100% on that. Too much time has passed.
>
> I added the MAC version to the driver banner, which should make it
> easier to figure out which MAC you have, and to change that function if
> it does not work for you out of the box. It seems that some chips don't
> work with this at all, based on testing by Michael Riepe (XID 3c4000c0).
>
> As should be obvious, this isn't ready to go anywhere near upstream yet
> I think.
>
Applied to 2.6.31.1 (i cannot run latest git, it is loaded proxy, too much
risk) (one reject only, fixed by hand).
[ 0.793643] r8169 Gigabit Ethernet driver 2.3LK-NAPI-TSO loaded
[ 0.793734] r8169 0000:03:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
[ 0.793842] r8169 0000:03:00.0: setting latency timer to 64
[ 0.793898] r8169 0000:03:00.0: irq 27 for MSI/MSI-X
[ 0.794188] eth0: RTL8168d/8111d (25) at 0xf8420000, 00:1c:c0:c2:4d:df, XID
281000c0 IRQ 27
[ 2.110317] r8169: eth0: link down
[ 2.110396] r8169: eth0: link down
[ 3.872590] r8169: eth0: link up
Working fine now, now when i enable TX checksumming it doesn't fail. I will
run for a while with tx checksumming, and then i will run the rest and will
do some performance measurements (by perf tool) and i will try on a little
bit other model of motherboard.
Thanks a lot for your patch!
prev parent reply other threads:[~2009-09-25 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 6:15 r8169, enabling TX checksumming breaks things? Denys Fedoryschenko
2009-09-23 14:02 ` David Dillow
2009-09-23 14:24 ` Denys Fedoryschenko
2009-09-24 1:12 ` David Dillow
2009-09-25 23:18 ` Denys Fedoryschenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909260218.54899.denys@visp.net.lb \
--to=denys@visp.net.lb \
--cc=dave@thedillows.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).