From: David Miller <davem@davemloft.net>
To: bhavesh@vmware.com
Cc: arnd@arndb.de, chrisw@sous-sol.org, pv-drivers@vmware.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, greg@kroah.com,
anthony@codemonkey.ws, jgarzik@pobox.com,
akpm@linux-foundation.org, shemminger@linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3
Date: Tue, 29 Sep 2009 12:55:30 -0700 (PDT) [thread overview]
Message-ID: <20090929.125530.31894576.davem@davemloft.net> (raw)
In-Reply-To: <8B1F619C9F5F454E81D90D3C161698D7017DB76582@EXCH-MBX-3.vmware.com>
From: Bhavesh Davda <bhavesh@vmware.com>
Date: Tue, 29 Sep 2009 12:52:05 -0700
>> One thing that should possibly be fixed is the naming of identifiers,
>> e.g.
>> 's/Vmxnet3_MiscConf/vmxnet3_misc_conf/g', unless these header files are
>> shared with the host implementation.
>
> These header files are indeed shared with the host implementation, as you've guessed. If it's not a big deal, we would like to keep the names the same, just for our own sanity's sake?
No. This isn't your source tree, it's everyone's. So you should
adhere to basic naming conventions and coding standards of the
tree regardless of what you happen to use or need to use internally.
next prev parent reply other threads:[~2009-09-29 19:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 23:56 [PATCH 2.6.31-rc9] net: VMware virtual Ethernet NIC driver: vmxnet3 Shreyas Bhatewara
2009-09-29 0:08 ` David Miller
2009-09-29 16:37 ` Shreyas Bhatewara
2009-09-29 0:20 ` Greg KH
2009-09-29 0:47 ` [Pv-drivers] " Alok Kataria
2009-09-29 0:22 ` Greg KH
2009-09-29 0:51 ` [Pv-drivers] " Alok Kataria
2009-09-29 1:17 ` David Miller
2009-09-29 8:53 ` Chris Wright
2009-09-29 13:05 ` Arnd Bergmann
2009-09-29 19:52 ` [Pv-drivers] " Bhavesh Davda
2009-09-29 19:55 ` David Miller [this message]
2009-09-29 21:23 ` Arnd Bergmann
2009-09-29 19:45 ` Bhavesh Davda
2009-09-29 20:30 ` Chris Wright
2009-09-29 21:00 ` Bhavesh Davda
2009-09-29 21:54 ` Chris Wright
2009-09-29 20:56 ` Shreyas Bhatewara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929.125530.31894576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=arnd@arndb.de \
--cc=bhavesh@vmware.com \
--cc=chrisw@sous-sol.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=shemminger@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).