From: Oleg Nesterov <oleg@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Evgeny Polyakov <johnpol@2ka.mipt.ru>,
Scott James Remnant <scott@ubuntu.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Evgeniy Polyakov <zbr@ioremap.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...)
Date: Tue, 29 Sep 2009 15:59:59 +0200 [thread overview]
Message-ID: <20090929135959.GA6806@redhat.com> (raw)
In-Reply-To: <200909291547.21528.borntraeger@de.ibm.com>
On 09/29, Christian Borntraeger wrote:
>
> --- linux-2.6.orig/kernel/sys.c
> +++ linux-2.6/kernel/sys.c
> @@ -1110,6 +1110,8 @@ SYSCALL_DEFINE0(setsid)
> err = session;
> out:
> write_unlock_irq(&tasklist_lock);
> + if (!err)
> + proc_sid_connector(sid);
sys_setsid() returns the session nr on success, not zero.
if (err > 0)
proc_sid_connector(sid);
Otherwize I think the patch is fine. Not only it should fix the problem,
imho it makes the code cleaner.
If Scott still thinks daemonize() should report too, we can change it.
(I'd suggest you to CC Andrew if you are going to re-send)
Oleg.
next prev parent reply other threads:[~2009-09-29 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200909251123.03482.borntraeger@de.ibm.com>
[not found] ` <200909291226.28548.borntraeger@de.ibm.com>
[not found] ` <fbbbe0a028fa.4ac1f1c0@2ka.mipt.ru>
2009-09-29 13:24 ` 2.3.31++: Badness at kernel/softirq.c:143 due to new session leader connector Oleg Nesterov
2009-09-29 13:47 ` [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...) Christian Borntraeger
2009-09-29 13:59 ` Oleg Nesterov [this message]
2009-09-29 14:07 ` Evgeniy Polyakov
2009-09-29 14:15 ` Christian Borntraeger
2009-09-29 14:25 ` Oleg Nesterov
2009-09-29 14:45 ` Oleg Nesterov
2009-09-29 15:12 ` Christian Borntraeger
2009-09-29 16:28 ` Oleg Nesterov
2009-09-30 6:43 ` [PATCH] connector: Fix regression introduced by sid connector Christian Borntraeger
2009-10-01 21:14 ` Andrew Morton
2009-10-01 22:29 ` Oleg Nesterov
2009-10-02 6:16 ` Christian Borntraeger
2009-10-14 0:53 ` David Rientjes
2009-09-29 17:07 ` [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...) Evgeniy Polyakov
2009-09-29 14:54 ` Evgeniy Polyakov
2009-09-29 15:36 ` Oleg Nesterov
2009-09-29 17:08 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929135959.GA6806@redhat.com \
--to=oleg@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=davem@davemloft.net \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=scott@ubuntu.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).