From mboxrd@z Thu Jan 1 00:00:00 1970 From: Evgeniy Polyakov Subject: Re: [PATCH] connector: Fix sid connector (was: Badness at kernel/softirq.c:143...) Date: Tue, 29 Sep 2009 18:54:13 +0400 Message-ID: <20090929145413.GA26327@ioremap.net> References: <200909251123.03482.borntraeger@de.ibm.com> <20090929132415.GB4538@redhat.com> <200909291547.21528.borntraeger@de.ibm.com> <20090929140718.GA23858@ioremap.net> <20090929142538.GA10180@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christian Borntraeger , Evgeny Polyakov , Scott James Remnant , Linux Kernel , Matt Helsley , "David S. Miller" , netdev@vger.kernel.org To: Oleg Nesterov Return-path: Content-Disposition: inline In-Reply-To: <20090929142538.GA10180@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Sep 29, 2009 at 04:25:38PM +0200, Oleg Nesterov (oleg@redhat.com) wrote: > > --- a/kernel/sys.c > > +++ b/kernel/sys.c > > @@ -1090,6 +1090,7 @@ SYSCALL_DEFINE0(setsid) > > struct pid *sid = task_pid(group_leader); > > pid_t session = pid_vnr(sid); > > int err = -EPERM; > > + int send_cn = 0; > > > > write_lock_irq(&tasklist_lock); > > /* Fail if I am already a session leader */ > > @@ -1104,12 +1105,18 @@ SYSCALL_DEFINE0(setsid) > > > > group_leader->signal->leader = 1; > > __set_special_pids(sid); > > + if (task_session(group_leader) != sid) > > + send_cn = 1; > > This is not right, task_session(group_leader) must be == sid after > __set_special_pids(). Yeah, that check should be done before __set_special_pids(). > And I don't think "int send_cn" is needed. sys_setsid() must not > succeed if the caller lived in session == task_pid(group_leader). Doesn't it only check pgid while patch intention was to send notification about sid? I.e. setsid() succeeds, although nothing happens. -- Evgeniy Polyakov