* [PATCH] sit: fix off-by-one in ipip6_tunnel_get_prl
@ 2009-09-29 21:27 Sascha Hlusiak
2009-09-30 23:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hlusiak @ 2009-09-29 21:27 UTC (permalink / raw)
To: netdev; +Cc: fred.l.templin, Sascha Hlusiak
When requesting all prl entries (kprl.addr == INADDR_ANY) and there are
more prl entries than there is space passed from userspace, the existing
code would always copy cmax+1 entries, which is more than can be handled.
This patch makes the kernel copy only exactly cmax entries.
Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
Acked-By: Fred L. Templin <Fred.L.Templin@boeing.com>
---
net/ipv6/sit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index d65e0c4..dbd19a7 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -274,7 +274,7 @@ static int ipip6_tunnel_get_prl(struct ip_tunnel *t,
c = 0;
for (prl = t->prl; prl; prl = prl->next) {
- if (c > cmax)
+ if (c >= cmax)
break;
if (kprl.addr != htonl(INADDR_ANY) && prl->addr != kprl.addr)
continue;
--
1.6.5.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sit: fix off-by-one in ipip6_tunnel_get_prl
2009-09-29 21:27 [PATCH] sit: fix off-by-one in ipip6_tunnel_get_prl Sascha Hlusiak
@ 2009-09-30 23:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-09-30 23:40 UTC (permalink / raw)
To: contact; +Cc: netdev, fred.l.templin
From: Sascha Hlusiak <contact@saschahlusiak.de>
Date: Tue, 29 Sep 2009 23:27:05 +0200
> When requesting all prl entries (kprl.addr == INADDR_ANY) and there are
> more prl entries than there is space passed from userspace, the existing
> code would always copy cmax+1 entries, which is more than can be handled.
>
> This patch makes the kernel copy only exactly cmax entries.
>
> Signed-off-by: Sascha Hlusiak <contact@saschahlusiak.de>
> Acked-By: Fred L. Templin <Fred.L.Templin@boeing.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-30 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-29 21:27 [PATCH] sit: fix off-by-one in ipip6_tunnel_get_prl Sascha Hlusiak
2009-09-30 23:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).