From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: sbhatewara@vmware.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, shemminger@linux-foundation.org,
jgarzik@pobox.com, anthony@codemonkey.ws, chrisw@sous-sol.org,
greg@kroah.com, akpm@linux-foundation.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com
Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3
Date: Wed, 30 Sep 2009 19:51:23 -0700 (PDT) [thread overview]
Message-ID: <20090930.195123.33813752.davem@davemloft.net> (raw)
In-Reply-To: <20090930173923.4520716a@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 30 Sep 2009 17:39:23 -0700
> Why not use NETIF_F_LRO and ethtool to control LRO support?
In fact, you must, in order to handle bridging and routing
correctly.
Bridging and routing is illegal with LRO enabled, so the kernel
automatically issues the necessary ethtool commands to disable
LRO in the relevant devices.
Therefore you must support the ethtool LRO operation in order to
support LRO at all.
next prev parent reply other threads:[~2009-10-01 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 21:34 [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3 Shreyas Bhatewara
2009-10-01 0:39 ` Stephen Hemminger
2009-10-01 1:18 ` Shreyas Bhatewara
2009-10-01 2:51 ` David Miller [this message]
2009-10-01 22:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930.195123.33813752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
--cc=shemminger@linux-foundation.org \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).