From: David Miller <davem@davemloft.net>
To: rjw@sisk.pl
Cc: avorontsov@ru.mvista.com, stern@rowland.harvard.edu,
linux-pm@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] 3c59x: Rework suspend and resume
Date: Wed, 30 Sep 2009 20:11:19 -0700 (PDT) [thread overview]
Message-ID: <20090930.201119.136086134.davem@davemloft.net> (raw)
In-Reply-To: <200909252354.34511.rjw@sisk.pl>
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Fri, 25 Sep 2009 23:54:34 +0200
> On Friday 25 September 2009, Anton Vorontsov wrote:
>> As noticed by Alan Stern, there is still one issue with the driver:
>> we disable PCI IRQ on suspend, but other devices on the same IRQ
>> line might still need the IRQ enabled to suspend properly.
>>
>> Nowadays, PCI core handles all power management work by itself, with
>> one condition though: if we use dev_pm_ops. So, rework the driver to
>> only quiesce 3c59x internal logic on suspend, while PCI core will
>> manage PCI device power state with IRQs disabled.
>>
>> Suggested-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Applied, thanks everyone.
prev parent reply other threads:[~2009-10-01 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 20:52 [PATCH] 3c59x: Rework suspend and resume Anton Vorontsov
2009-09-25 21:54 ` Rafael J. Wysocki
2009-10-01 3:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930.201119.136086134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avorontsov@ru.mvista.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).