From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Matthew Carlson" <mcarlson@broadcom.com>,
"Linux Netdev List" <netdev@vger.kernel.org>,
"Michael Chan" <mchan@broadcom.com>
Subject: Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
Date: Wed, 30 Sep 2009 10:26:43 -0700 [thread overview]
Message-ID: <20090930172643.GA14439@xw6200.broadcom.net> (raw)
In-Reply-To: <4AC36638.8070304@gmail.com>
On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote:
> prev_vlan_tag field is not used.
>
> Patch saves 512*8 bytes per tx queue ring on 64bit arches.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks good to me.
Acked-by: Matthew Carlson <mcarlson@broadcom.com>
> ---
>
> diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h
> index 82b45d8..524691c 100644
> --- a/drivers/net/tg3.h
> +++ b/drivers/net/tg3.h
> @@ -2412,7 +2412,6 @@ struct ring_info {
>
> struct tx_ring_info {
> struct sk_buff *skb;
> - u32 prev_vlan_tag;
> };
>
> struct tg3_config_info {
>
next prev parent reply other threads:[~2009-09-30 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 14:07 [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info Eric Dumazet
2009-09-30 17:26 ` Matt Carlson [this message]
2009-10-01 21:38 ` David Miller
2009-10-02 4:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930172643.GA14439@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).