From: David Miller <davem@davemloft.net>
To: mb@bu3sch.de
Cc: johannes@sipsolutions.net, oliver@hartkopp.net,
kalle.valo@iki.fi, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fix NOHZ: local_softirq_pending 08
Date: Thu, 01 Oct 2009 12:32:52 -0700 (PDT) [thread overview]
Message-ID: <20091001.123252.114903468.davem@davemloft.net> (raw)
In-Reply-To: <200910012110.34216.mb@bu3sch.de>
From: Michael Buesch <mb@bu3sch.de>
Date: Thu, 1 Oct 2009 21:10:32 +0200
> For the benefit of a much bigger critical section? I don't get it
> why this would be any better.
Think about what you are saying when you introduce things
like this into your code:
if (in_interrupt())
foo();
else
bar();
That thing there means you don't know anything about how you'll need
to do locking properly, because you have no idea about even the
context in which your code is executed.
Sure, you can lock for the most stringent case, but that's silly and
wasteful.
prev parent reply other threads:[~2009-10-01 19:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 14:48 mac80211: NOHZ: local_softirq_pending 08 Michael Buesch
2009-09-11 14:57 ` Kalle Valo
2009-09-11 15:07 ` Michael Buesch
[not found] ` <200909111707.23971.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-09-11 16:07 ` Kalle Valo
2009-09-11 16:07 ` Oliver Hartkopp
[not found] ` <4AAA75CB.6040803-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2009-09-11 16:13 ` Michael Buesch
2009-09-12 16:41 ` Oliver Hartkopp
[not found] ` <4AABCF28.6090505-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2009-09-12 16:51 ` Michael Buesch
[not found] ` <200909121851.46002.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-09-12 18:07 ` Oliver Hartkopp
2009-09-29 19:29 ` John W. Linville
[not found] ` <20090929192928.GF2678-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-09-30 11:56 ` Oliver Hartkopp
2009-09-30 14:33 ` Michael Buesch
[not found] ` <200909301633.04376.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-09-30 14:47 ` Kalle Valo
2009-09-30 14:54 ` Johannes Berg
[not found] ` <1254322466.3959.5.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-09-30 15:10 ` Michael Buesch
2009-09-30 15:21 ` Johannes Berg
[not found] ` <1254324077.3959.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-09-30 17:51 ` Oliver Hartkopp
[not found] ` <4AC39A90.6060602-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2009-09-30 18:18 ` [PATCH] net: fix " Oliver Hartkopp
[not found] ` <4AC3A0F1.3060306-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2009-09-30 18:47 ` John W. Linville
2009-09-30 23:33 ` David Miller
2009-10-01 7:08 ` Oliver Hartkopp
2009-10-01 14:04 ` Michael Buesch
[not found] ` <200910011604.42916.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-10-01 14:24 ` Kalle Valo
2009-10-01 18:42 ` Johannes Berg
[not found] ` <1254422548.3959.24.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-10-01 19:10 ` Michael Buesch
[not found] ` <200910012110.34216.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-10-01 19:26 ` Johannes Berg
2009-10-01 19:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.123252.114903468.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).