From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/7] mlx4: Query for loopback support
Date: Thu, 01 Oct 2009 13:34:44 -0700 (PDT) [thread overview]
Message-ID: <20091001.133444.116815514.davem@davemloft.net> (raw)
In-Reply-To: <4AC4BDB7.2040306@mellanox.co.il>
From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Thu, 01 Oct 2009 16:33:27 +0200
> + int loopback_support;
You don't need a full 32-bit integer to store what
amounts to a single bit of boolean state.
Please store this in a flags word somewhere, or
if nothing appropriate exists, use a 'bool'.
prev parent reply other threads:[~2009-10-01 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 14:33 [PATCH 2/7] mlx4: Query for loopback support Yevgeny Petrilin
2009-10-01 20:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.133444.116815514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).