From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: eric.dumazet@gmail.com, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [RFC] pkt_sched: gen_estimator: Dont report fake rate estimators
Date: Thu, 01 Oct 2009 14:14:06 -0700 (PDT) [thread overview]
Message-ID: <20091001.141406.62574384.davem@davemloft.net> (raw)
In-Reply-To: <4AC519B1.1090701@gmail.com>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Thu, 01 Oct 2009 23:05:53 +0200
> Since you ask... I wonder about this whole int plus quite a bit of
> struct unreadability for one flag only. Maybe it could be queried
> on qdisc level (with a flag if necessary), and additional parameter
> of gnet_stats_copy_rate_est()? (Qdiscs should have no problem with
> setting this param for their classes too.)
Certainly, that's another approach to this problem.
But logically, just like we wouldn't emit a block of RED scheduler
data to 'tc' unless RED is actually configured, it seems consistent to
not emit estimator data when no estimator is even there.
next prev parent reply other threads:[~2009-10-01 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 19:07 [RFC] pkt_sched: gen_estimator: Dont report fake rate estimators Eric Dumazet
2009-10-01 19:37 ` David Miller
2009-10-01 21:05 ` Jarek Poplawski
2009-10-01 21:14 ` David Miller [this message]
2009-10-01 21:21 ` Jarek Poplawski
2009-10-02 7:08 ` Jarek Poplawski
2009-10-02 7:12 ` Eric Dumazet
2009-10-02 7:17 ` Jarek Poplawski
2009-10-02 7:32 ` Jarek Poplawski
2009-10-02 10:35 ` [RFC take2] " Eric Dumazet
2009-10-02 11:25 ` Jarek Poplawski
2009-10-02 12:39 ` Eric Dumazet
2009-10-02 20:11 ` Jarek Poplawski
2009-10-02 20:32 ` Eric Dumazet
2009-10-07 8:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.141406.62574384.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).