WOL with flex filters, reflecting it in /sys

WOL with flex filters, reflecting it in /sys

[Leisner, Martin]

I'm looking to extend the work of Mitch Williams to support flexible
filters.
(http://www.mail-archive.com/netdev@vger.kernel.org/msg60332.html}

Looking at the problem, would it be a good idea to reflect WOL
characteristics in the /sys filesystem (instead of requiring ethtool to
set them)?

Seems straightforward and easy enough.

I know the VIA Rhinefet and Intel e1000 support filters -- and some
freescale
seems to have some front end that support filters...and we've also
implemented filters in software...

What I'm thinking of is a hierarchy in /sys/classes/net/<device>/wol/

wol/
   /flex-filters
      /0
           data -- hex data to match
           mask -- string of 1 and 0 -- if 1, the data is valid in the
bit 
                   position
      ...
      /n
	   data
         mask
  /wake_up_packet
  /traditional --r/w (0/1)
     /magic_packet
     /arp
     /unicast
     /multicast
     /broadcast
     /phy
    
marty

Re: WOL with flex filters, reflecting it in /sys

[David Miller]

From: "Leisner, Martin" <Martin.Leisner@xerox.com>
Date: Thu, 1 Oct 2009 13:55:03 -0700

> What I'm thinking of is a hierarchy in /sys/classes/net/<device>/wol/
> 
> wol/
>    /flex-filters
>       /0
>            data -- hex data to match
>            mask -- string of 1 and 0 -- if 1, the data is valid in the
> bit 
>                    position
>       ...
>       /n
> 	   data
>          mask
>   /wake_up_packet
>   /traditional --r/w (0/1)
>      /magic_packet
>      /arp
>      /unicast
>      /multicast
>      /broadcast
>      /phy

That's a pretty hairy interface for users to learn.  Are you
really sure this is nicer than adding this facility to ethtool? :-)

Re: [linux-pm] WOL with flex filters, reflecting it in /sys

[Rafael J. Wysocki]

On Thursday 01 October 2009, Leisner, Martin wrote:
> I'm looking to extend the work of Mitch Williams to support flexible
> filters.
> (http://www.mail-archive.com/netdev@vger.kernel.org/msg60332.html}
> 
> Looking at the problem, would it be a good idea to reflect WOL
> characteristics in the /sys filesystem (instead of requiring ethtool to
> set them)?
> 
> Seems straightforward and easy enough.

I'm not sure about that.

The supported WoL settings seem to depend on the driver and whether WoL is
going to work also depends on the device's power/wakeup setting.

Thanks,
Rafael