From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info
Date: Thu, 01 Oct 2009 14:38:59 -0700 (PDT) [thread overview]
Message-ID: <20091001.143859.53379358.davem@davemloft.net> (raw)
In-Reply-To: <20090930172643.GA14439@xw6200.broadcom.net>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Wed, 30 Sep 2009 10:26:43 -0700
> On Wed, Sep 30, 2009 at 07:07:52AM -0700, Eric Dumazet wrote:
>> prev_vlan_tag field is not used.
>>
>> Patch saves 512*8 bytes per tx queue ring on 64bit arches.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Looks good to me.
>
> Acked-by: Matthew Carlson <mcarlson@broadcom.com>
Applied, thanks.
Eric, I had to apply this by hand because:
>> @@ -2412,7 +2412,6 @@ struct ring_info {
>>
>> struct tx_ring_info {
>> struct sk_buff *skb;
>> - u32 prev_vlan_tag;
>> };
Your email client changed tabs into spaces.
next prev parent reply other threads:[~2009-10-01 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 14:07 [PATCH] tg3: Remove prev_vlan_tag from struct tx_ring_info Eric Dumazet
2009-09-30 17:26 ` Matt Carlson
2009-10-01 21:38 ` David Miller [this message]
2009-10-02 4:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.143859.53379358.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).