From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: atis@mikrotik.com, panther@balabit.hu, netdev@vger.kernel.org
Subject: Re: [PATCH] Use sk_mark for routing lookup in more places
Date: Thu, 01 Oct 2009 15:18:23 -0700 (PDT) [thread overview]
Message-ID: <20091001.151823.263194343.davem@davemloft.net> (raw)
In-Reply-To: <4AC4D90E.3040008@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 01 Oct 2009 18:30:06 +0200
> Atis Elsts a écrit :
>> This patch against v2.6.31 adds support for route lookup using sk_mark in some
>> more places. The benefits from this patch are the following.
>> First, SO_MARK option now has effect on UDP sockets too.
>> Second, ip_queue_xmit() and inet_sk_rebuild_header() could fail to do routing
>> lookup correctly if TCP sockets with SO_MARK were used.
>>
>> Signed-off-by: Atis Elsts <atis@mikrotik.com>
>
> Good catch, thanks !
>
> I used SO_MARK on connected UDP sockets so did not notice the lack
> of functionality. (ip_route_connect() does use sk->sk_mark)
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
But Atis, your patch was whitespace corrupted by your email
client so I had to apply your patch by hand. Please correct
this problem before submitting future patches, thank you.
next prev parent reply other threads:[~2009-10-01 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 15:14 [PATCH] Use sk_mark for routing lookup in more places Atis Elsts
2009-10-01 16:30 ` Eric Dumazet
2009-10-01 22:18 ` David Miller [this message]
2009-10-02 5:14 ` Eric Dumazet
2009-10-02 6:08 ` Eric Dumazet
2009-10-02 17:25 ` Maciej Żenczykowski
2009-10-02 18:00 ` David Miller
2009-10-02 18:19 ` [PATCH] Use sk_mark for IPv6 routing lookups Brian Haley
2009-10-05 12:55 ` Atis Elsts
2009-10-05 18:24 ` Brian Haley
2009-10-07 8:29 ` David Miller
2009-10-07 8:27 ` [PATCH] Use sk_mark for routing lookup in more places David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.151823.263194343.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atis@mikrotik.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).