netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: holger.hoffstaette@googlemail.com, netdev@vger.kernel.org,
	eric.dumazet@gmail.com, ilpo.jarvinen@helsinki.fi
Subject: Re: Network hangs with 2.6.30.5
Date: Thu, 01 Oct 2009 15:49:13 -0700 (PDT)	[thread overview]
Message-ID: <20091001.154913.88345178.davem@davemloft.net> (raw)
In-Reply-To: <20090907072143.GA5966@ff.dom.local>

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 7 Sep 2009 07:21:43 +0000

> While Eric is analyzing your data, I guess you could try reverting
> some stuff around this tcp_tw_recycle, and my tcp ignorance would
> point these commits for the beginning:
> 
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.30.y.git;a=commitdiff;h=fc1ad92dfc4e363a055053746552cdb445ba5c57
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.30.y.git;a=commitdiff;h=c887e6d2d9aee56ee7c9f2af4cec3a5efdcc4c72

Ilpo's cleanup (the second commit listed) looks most likely to
be a possibility.

But I surely cannot find any bugs in it, even after studying it
a few times.

Ilpo could you audit it one more time for us just in case?

I also looked through all the TCP commits in 2.6.29 to 2.6.30
and I could not find anything else that might cause stalls with
time-wait recycled connections.

  parent reply	other threads:[~2009-10-01 22:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01  9:50 Network hangs with 2.6.30.5 Clifford Heath
2009-09-01 10:47 ` Eric Dumazet
2009-09-01 11:20 ` Ben Hutchings
2009-09-01 14:17 ` Holger Hoffstaette
2009-09-01 15:32   ` Holger Hoffstaette
2009-09-03  7:46     ` Jarek Poplawski
2009-09-03 19:20       ` Holger Hoffstaette
2009-09-03 19:27         ` Eric Dumazet
2009-09-03 19:55           ` Holger Hoffstaette
2009-09-07  7:21             ` Jarek Poplawski
2009-09-10 22:41               ` Clifford Heath
2009-10-01 22:49               ` David Miller [this message]
2009-10-02  8:11                 ` Ilpo Järvinen
2009-10-02 12:29                   ` Ilpo Järvinen
2009-10-02 12:38                     ` Eric Dumazet
2009-11-19 23:40                   ` David Miller
2009-11-20 12:04                     ` Evgeniy Polyakov
2009-11-20 12:09                       ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091001.154913.88345178.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=holger.hoffstaette@googlemail.com \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).