From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: yevgenyp@mellanox.co.il, netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] mlx4: Added interrupts test support
Date: Thu, 01 Oct 2009 22:27:15 -0700 (PDT) [thread overview]
Message-ID: <20091001.222715.166183229.davem@davemloft.net> (raw)
In-Reply-To: <adaeipmqxmv.fsf@cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 01 Oct 2009 20:32:08 -0700
> This feels like a pretty risky thing to do while the device might be
> handling all sorts of other traffic at the same time. Are you sure
> there are no races you expose here? Have you actually seen cases where
> the interrupt test during initialization works but then this test
> catches a problem? (My experience has been that if any MSI-X interrupts
> work from a device, then they'll all work)
I would suggest only allowing the test while the interface is down.
That way the test has exclusive control of the IRQ.
next prev parent reply other threads:[~2009-10-02 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 14:32 [PATCH 1/7] mlx4: Added interrupts test support Yevgeny Petrilin
2009-10-02 3:32 ` Roland Dreier
2009-10-02 5:27 ` David Miller [this message]
2009-10-05 11:16 ` Yevgeny Petrilin
2009-10-05 16:18 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001.222715.166183229.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).