From: Stephen Hemminger <shemminger@vyatta.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: irqname based on pci address
Date: Thu, 1 Oct 2009 10:14:50 -0700 [thread overview]
Message-ID: <20091001101450.371a2982@s6510> (raw)
In-Reply-To: <20091001101146.3368b4a4@s6510>
On Thu, 1 Oct 2009 10:11:46 -0700
Stephen Hemminger <shemminger@vyatta.com> wrote:
> This is based on Michal Schmidt fix for skge.
>
> Most network drivers request their IRQ when the interface is activated.
> sky2 does it in ->probe() instead, because it can work with two-port
> cards where the two net_devices use the same IRQ. This works fine most
> of the time, except in some situations when the interface gets renamed.
> Consider this example:
>
> 1. modprobe sky2
> The card is detected as eth0 and requests IRQ 17. Directory
> /proc/irq/17/eth0 is created.
> 2. There is an udev rule which says this interface should be called
> eth1, so udev renames eth0 -> eth1.
> 3. modprobe 8139too
> The Realtek card is detected as eth0. It will be using IRQ 17 too.
> 4. ip link set eth0 up
> Now 8139too requests IRQ 17.
One other note, the issue is less of a problem for most usage of sky2
because the drive is used mostly on systems that support MSI interrupts
which can never be shared.
next prev parent reply other threads:[~2009-10-01 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 12:01 [PATCH] skge: request IRQ on activating the interface Michal Schmidt
2009-09-22 16:28 ` Stephen Hemminger
2009-10-01 10:27 ` [PATCH] skge: use unique IRQ name Michal Schmidt
2009-10-01 16:06 ` Stephen Hemminger
2009-10-01 16:50 ` Stephen Hemminger
2009-10-01 18:02 ` Michal Schmidt
2009-10-01 18:13 ` [PATCH v3] " Stephen Hemminger
2009-10-01 20:31 ` David Miller
2009-10-01 22:17 ` David Miller
2009-10-01 17:11 ` [PATCH] sky2: irqname based on pci address Stephen Hemminger
2009-10-01 17:14 ` Stephen Hemminger [this message]
2009-10-01 18:03 ` Michal Schmidt
2009-10-01 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001101450.371a2982@s6510 \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox