From: Michal Schmidt <mschmidt@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] skge: use unique IRQ name
Date: Thu, 1 Oct 2009 20:02:08 +0200 [thread overview]
Message-ID: <20091001200208.2907b8ff@leela> (raw)
In-Reply-To: <20091001095032.17271dcc@s6510>
Dne Thu, 1 Oct 2009 09:50:32 -0700 Stephen Hemminger napsal:
> err = -ENOMEM;
> - hw = kzalloc(sizeof(*hw), GFP_KERNEL);
> + /* space for skge@pci:0000:04:00.0 */
> + irq_name_len = strlen(DRV_NAME) +
> strlen(dev_name(&pdev->dev)) + 6;
You replaced "dev_name(&pdev->dev)" with "pci_name(pdev)" below.
That's nice, so we should replace it here too for consistency.
> + hw = kzalloc(sizeof(*hw) + irq_name_len, GFP_KERNEL);
> if (!hw) {
> dev_err(&pdev->dev, "cannot allocate hardware
> struct\n"); goto err_out_free_regions;
> }
> + sprintf(hw->irq_name, DRV_NAME "@pci:%s", pci_name(pdev));
Michal
next prev parent reply other threads:[~2009-10-01 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 12:01 [PATCH] skge: request IRQ on activating the interface Michal Schmidt
2009-09-22 16:28 ` Stephen Hemminger
2009-10-01 10:27 ` [PATCH] skge: use unique IRQ name Michal Schmidt
2009-10-01 16:06 ` Stephen Hemminger
2009-10-01 16:50 ` Stephen Hemminger
2009-10-01 18:02 ` Michal Schmidt [this message]
2009-10-01 18:13 ` [PATCH v3] " Stephen Hemminger
2009-10-01 20:31 ` David Miller
2009-10-01 22:17 ` David Miller
2009-10-01 17:11 ` [PATCH] sky2: irqname based on pci address Stephen Hemminger
2009-10-01 17:14 ` Stephen Hemminger
2009-10-01 18:03 ` Michal Schmidt
2009-10-01 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001200208.2907b8ff@leela \
--to=mschmidt@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).