From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: eric.dumazet@gmail.com, atis@mikrotik.com, panther@balabit.hu,
netdev@vger.kernel.org
Subject: Re: [PATCH] Use sk_mark for routing lookup in more places
Date: Fri, 02 Oct 2009 11:00:49 -0700 (PDT) [thread overview]
Message-ID: <20091002.110049.252043637.davem@davemloft.net> (raw)
In-Reply-To: <55a4f86e0910021025u7523029av1e4ee917d1fb1ee5@mail.gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Fri, 2 Oct 2009 10:25:13 -0700
> Maybe it would make more sense to create some constructor-like
> functions for the flowi struct?
Maybe just an initializer like "FLOWI_SOCK(sk)" or similar.
So you can say:
struct flowi fl = FLOWI_SOCK(sk);
But the thing is we usually want to initialize all of the
details in one go, so we'd need a very messy macro for this
that would take many arguments.
It's important to use an initializer rather than assignments in some
inline function so that GCC can better coalesce many small members
into since large stores to the stack. It doesn't do this as well with
real assignment statements.
next prev parent reply other threads:[~2009-10-02 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 15:14 [PATCH] Use sk_mark for routing lookup in more places Atis Elsts
2009-10-01 16:30 ` Eric Dumazet
2009-10-01 22:18 ` David Miller
2009-10-02 5:14 ` Eric Dumazet
2009-10-02 6:08 ` Eric Dumazet
2009-10-02 17:25 ` Maciej Żenczykowski
2009-10-02 18:00 ` David Miller [this message]
2009-10-02 18:19 ` [PATCH] Use sk_mark for IPv6 routing lookups Brian Haley
2009-10-05 12:55 ` Atis Elsts
2009-10-05 18:24 ` Brian Haley
2009-10-07 8:29 ` David Miller
2009-10-07 8:27 ` [PATCH] Use sk_mark for routing lookup in more places David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002.110049.252043637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atis@mikrotik.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).