From: David Miller <davem@davemloft.net>
To: william.allen.simpson@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl
Date: Fri, 02 Oct 2009 15:48:08 -0700 (PDT) [thread overview]
Message-ID: <20091002.154808.137771153.davem@davemloft.net> (raw)
In-Reply-To: <4AC674A4.2040900@gmail.com>
From: William Allen Simpson <william.allen.simpson@gmail.com>
Date: Fri, 02 Oct 2009 17:46:12 -0400
> Andi Kleen wrote:
>> William Allen Simpson <william.allen.simpson@gmail.com> writes:
>>> Any suggestions for improvement? Or general approval?
>> The patch seems incomplete, can't find callers for most of the new
>> functions.
>>
> Ummm, I was following the suggested practice of breaking it into
> smaller
> pieces for review. This is just the control functions and headers.
> I've
> actually completed most of the port, and am champing at the bit.
We can't review the helper functions and infrastructure properly until
we can see how they are actually used.
Seeing how they are used shows us how well they are designed.
Otherwise asking for a is absolutely pointless as we have no context
in which to judge the code you're showing us.
next prev parent reply other threads:[~2009-10-02 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 4:00 query: adding a sysctl William Allen Simpson
2009-10-02 5:57 ` Stephen Hemminger
2009-10-02 14:58 ` [PATCH] TCPCT-1: " William Allen Simpson
2009-10-02 17:52 ` William Allen Simpson
2009-10-02 22:00 ` William Allen Simpson
2009-10-02 21:06 ` Andi Kleen
2009-10-02 21:46 ` William Allen Simpson
2009-10-02 22:48 ` David Miller [this message]
2009-10-03 0:32 ` William Allen Simpson
2009-10-03 6:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002.154808.137771153.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).