From: Michael Buesch <mb@bu3sch.de>
To: Tilman Schmidt <tilman@imap.cc>
Cc: i4ldeveloper@listserv.isdn4linux.de,
Carsten Paeth <calle@calle.de>,
Karsten Keil <isdn@linux-pingi.de>,
Karsten Keil <keil@b1-systems.de>,
Armin Schindler <armin@melware.de>,
isdn4linux@listserv.isdn4linux.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit
Date: Sat, 3 Oct 2009 20:26:22 +0200 [thread overview]
Message-ID: <200910032026.24451.mb@bu3sch.de> (raw)
In-Reply-To: <20091003120657.2228911186C@xenon.ts.pxnet.com>
On Saturday 03 October 2009 14:06:57 Tilman Schmidt wrote:
> Move calls to handle_minor_send() and handle_minor_recv() out of
> the sections locked by workaround_lock.
> - handle_minor_send() may call another CAPI function via the card
> driver, deadlocking by trying to take workaround_lock again.
> - handle_minor_recv() calls the receive_buf method of the active
> line discipline which may sleep.
I remember that handle_minor_send() and/or handle_minor_recv() showed up
in the crash backtraces. So if you move them out of the critical
section, you can as well remove the lock completely.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-10-03 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 12:06 [PATCH RFC] isdn/capi: fix up CAPI subsystem workaround locking a bit Tilman Schmidt
2009-10-03 18:26 ` Michael Buesch [this message]
2009-10-03 18:35 ` Michael Buesch
[not found] ` <200910032035.21884.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-10-05 11:42 ` Tilman Schmidt
2009-10-05 21:24 ` Michael Buesch
2009-10-06 17:52 ` Tilman Schmidt
2009-10-06 21:01 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910032026.24451.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=armin@melware.de \
--cc=calle@calle.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=keil@b1-systems.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).