From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] wext: let get_wireless_stats() sleep Date: Mon, 05 Oct 2009 02:22:39 -0700 (PDT) Message-ID: <20091005.022239.95915308.davem@davemloft.net> References: <1254734159.22426.6.camel@johannes.local> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org Return-path: In-Reply-To: <1254734159.22426.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Johannes Berg Date: Mon, 05 Oct 2009 11:15:59 +0200 > A number of drivers (recently including cfg80211-based ones) > assume that all wireless handlers, including statistics, can > sleep and they often also implicitly assume that the rtnl is > held around their invocation. This is almost always true now > except when reading from sysfs: ... > Fix this by using the rtnl instead of dev_base_lock. > > Reported-by: Miles Lane > Signed-off-by: Johannes Berg Fair enough, applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html