* [PATCH] net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep
@ 2009-10-01 14:28 Tilman Schmidt
2009-10-07 8:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tilman Schmidt @ 2009-10-01 14:28 UTC (permalink / raw)
To: Alan Cox, Alan Cox, Paul Mackerras, linux-ppp
Cc: David Miller, netdev, Jarek Poplawski, linux-kernel
The receive_buf methods of the N_PPP and N_SYNC_PPP line disciplines,
ppp_asynctty_receive() and ppp_sync_receive(), call tty_unthrottle()
which may sleep. Fix the comments claiming otherwise.
Impact: documentation
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
drivers/net/ppp_async.c | 5 +----
drivers/net/ppp_synctty.c | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
index 6de8399..30b1b33 100644
--- a/drivers/net/ppp_async.c
+++ b/drivers/net/ppp_async.c
@@ -337,10 +337,7 @@ ppp_asynctty_poll(struct tty_struct *tty, struct file *file, poll_table *wait)
return 0;
}
-/*
- * This can now be called from hard interrupt level as well
- * as soft interrupt level or mainline.
- */
+/* May sleep, don't call from interrupt level or with interrupts disabled */
static void
ppp_asynctty_receive(struct tty_struct *tty, const unsigned char *buf,
char *cflags, int count)
diff --git a/drivers/net/ppp_synctty.c b/drivers/net/ppp_synctty.c
index d2fa2db..c908b08 100644
--- a/drivers/net/ppp_synctty.c
+++ b/drivers/net/ppp_synctty.c
@@ -378,10 +378,7 @@ ppp_sync_poll(struct tty_struct *tty, struct file *file, poll_table *wait)
return 0;
}
-/*
- * This can now be called from hard interrupt level as well
- * as soft interrupt level or mainline.
- */
+/* May sleep, don't call from interrupt level or with interrupts disabled */
static void
ppp_sync_receive(struct tty_struct *tty, const unsigned char *buf,
char *cflags, int count)
--
1.6.2.1.214.ge986c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep
2009-10-01 14:28 [PATCH] net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep Tilman Schmidt
@ 2009-10-07 8:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-07 8:28 UTC (permalink / raw)
To: tilman; +Cc: alan, alan, paulus, linux-ppp, netdev, jarkao2, linux-kernel
From: Tilman Schmidt <tilman@imap.cc>
Date: Thu, 1 Oct 2009 16:28:44 +0200 (CEST)
> The receive_buf methods of the N_PPP and N_SYNC_PPP line disciplines,
> ppp_asynctty_receive() and ppp_sync_receive(), call tty_unthrottle()
> which may sleep. Fix the comments claiming otherwise.
>
> Impact: documentation
> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-07 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-01 14:28 [PATCH] net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep Tilman Schmidt
2009-10-07 8:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).