* [PATCH] dcb: data center bridging ops should be r/o
@ 2009-10-05 16:01 Stephen Hemminger
2009-10-05 20:08 ` Peter P Waskiewicz Jr
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2009-10-05 16:01 UTC (permalink / raw)
To: Jeff Kirsher, Jesse Brandeburg, David Miller; +Cc: netdev, e1000-devel
The data center bridging ops structure can be const
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/ixgbe/ixgbe.h 2009-10-03 21:40:25.712809970 -0700
+++ b/drivers/net/ixgbe/ixgbe.h 2009-10-03 21:40:33.490342038 -0700
@@ -397,7 +397,7 @@ enum ixgbe_boards {
extern struct ixgbe_info ixgbe_82598_info;
extern struct ixgbe_info ixgbe_82599_info;
#ifdef CONFIG_IXGBE_DCB
-extern struct dcbnl_rtnl_ops dcbnl_ops;
+extern const struct dcbnl_rtnl_ops dcbnl_ops;
extern int ixgbe_copy_dcb_cfg(struct ixgbe_dcb_config *src_dcb_cfg,
struct ixgbe_dcb_config *dst_dcb_cfg,
int tc_max);
--- a/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-10-03 21:39:54.710299317 -0700
+++ b/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-10-03 21:40:05.990317034 -0700
@@ -563,7 +563,7 @@ static u8 ixgbe_dcbnl_setapp(struct net_
return rval;
}
-struct dcbnl_rtnl_ops dcbnl_ops = {
+const struct dcbnl_rtnl_ops dcbnl_ops = {
.getstate = ixgbe_dcbnl_get_state,
.setstate = ixgbe_dcbnl_set_state,
.getpermhwaddr = ixgbe_dcbnl_get_perm_hw_addr,
--- a/include/linux/netdevice.h 2009-10-03 21:40:52.730300256 -0700
+++ b/include/linux/netdevice.h 2009-10-03 21:41:10.362812001 -0700
@@ -909,7 +909,7 @@ struct net_device
#ifdef CONFIG_DCB
/* Data Center Bridging netlink ops */
- struct dcbnl_rtnl_ops *dcbnl_ops;
+ const struct dcbnl_rtnl_ops *dcbnl_ops;
#endif
#if defined(CONFIG_FCOE) || defined(CONFIG_FCOE_MODULE)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dcb: data center bridging ops should be r/o
2009-10-05 16:01 [PATCH] dcb: data center bridging ops should be r/o Stephen Hemminger
@ 2009-10-05 20:08 ` Peter P Waskiewicz Jr
2009-10-07 8:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Peter P Waskiewicz Jr @ 2009-10-05 20:08 UTC (permalink / raw)
To: Stephen Hemminger
Cc: netdev@vger.kernel.org, e1000-devel@lists.sf.net, David Miller,
Kirsher, Jeffrey T, Jesse Brandeburg
On Mon, 2009-10-05 at 09:01 -0700, Stephen Hemminger wrote:
> The data center bridging ops structure can be const
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
Thanks Stephen, that was an oversight.
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> --- a/drivers/net/ixgbe/ixgbe.h 2009-10-03 21:40:25.712809970 -0700
> +++ b/drivers/net/ixgbe/ixgbe.h 2009-10-03 21:40:33.490342038 -0700
> @@ -397,7 +397,7 @@ enum ixgbe_boards {
> extern struct ixgbe_info ixgbe_82598_info;
> extern struct ixgbe_info ixgbe_82599_info;
> #ifdef CONFIG_IXGBE_DCB
> -extern struct dcbnl_rtnl_ops dcbnl_ops;
> +extern const struct dcbnl_rtnl_ops dcbnl_ops;
> extern int ixgbe_copy_dcb_cfg(struct ixgbe_dcb_config *src_dcb_cfg,
> struct ixgbe_dcb_config *dst_dcb_cfg,
> int tc_max);
> --- a/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-10-03 21:39:54.710299317 -0700
> +++ b/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-10-03 21:40:05.990317034 -0700
> @@ -563,7 +563,7 @@ static u8 ixgbe_dcbnl_setapp(struct net_
> return rval;
> }
>
> -struct dcbnl_rtnl_ops dcbnl_ops = {
> +const struct dcbnl_rtnl_ops dcbnl_ops = {
> .getstate = ixgbe_dcbnl_get_state,
> .setstate = ixgbe_dcbnl_set_state,
> .getpermhwaddr = ixgbe_dcbnl_get_perm_hw_addr,
> --- a/include/linux/netdevice.h 2009-10-03 21:40:52.730300256 -0700
> +++ b/include/linux/netdevice.h 2009-10-03 21:41:10.362812001 -0700
> @@ -909,7 +909,7 @@ struct net_device
>
> #ifdef CONFIG_DCB
> /* Data Center Bridging netlink ops */
> - struct dcbnl_rtnl_ops *dcbnl_ops;
> + const struct dcbnl_rtnl_ops *dcbnl_ops;
> #endif
>
> #if defined(CONFIG_FCOE) || defined(CONFIG_FCOE_MODULE)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dcb: data center bridging ops should be r/o
2009-10-05 20:08 ` Peter P Waskiewicz Jr
@ 2009-10-07 8:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-10-07 8:30 UTC (permalink / raw)
To: peter.p.waskiewicz.jr
Cc: shemminger, jeffrey.t.kirsher, jesse.brandeburg, netdev,
e1000-devel
From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 05 Oct 2009 13:08:18 -0700
> On Mon, 2009-10-05 at 09:01 -0700, Stephen Hemminger wrote:
>> The data center bridging ops structure can be const
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>
> Thanks Stephen, that was an oversight.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-07 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-05 16:01 [PATCH] dcb: data center bridging ops should be r/o Stephen Hemminger
2009-10-05 20:08 ` Peter P Waskiewicz Jr
2009-10-07 8:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).