From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: felix@embedded-sol.com, netdev@vger.kernel.org,
mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH net-2.6 V2] tg3: Fix phylib locking strategy
Date: Wed, 07 Oct 2009 03:41:41 -0700 (PDT) [thread overview]
Message-ID: <20091007.034141.80564057.davem@davemloft.net> (raw)
In-Reply-To: <1254801692.18507@xw6200>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Mon, 5 Oct 2009 20:55:29 -0700
> O.K. Here is the latest version. Felix, can you verify your problem
> is solved with this patch?
>
> ---
>
> Felix Radensky noted that chip resets were generating stack trace dumps.
> This is because the driver is attempting to acquire the mdio bus mutex
> while holding the tp->lock spinlock. The fix is to change the code such
> that every phy access takes the tp->lock spinlock instead.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
I'm going to apply this now to net-2.6, let me know if there are
any updates after testing.
next prev parent reply other threads:[~2009-10-07 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 3:55 [PATCH net-2.6 V2] tg3: Fix phylib locking strategy Matt Carlson
2009-10-06 5:45 ` Felix Radensky
2009-10-07 10:41 ` David Miller [this message]
2009-11-16 20:53 ` Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007.034141.80564057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=felix@embedded-sol.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).