From: David Miller <davem@davemloft.net>
To: wg@grandegger.com
Cc: anantgole@ti.com, netdev@vger.kernel.org,
socketcan-core@lists.berlios.de,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [net-next-2.6 PATCH V2] can: add TI CAN (HECC) driver
Date: Wed, 07 Oct 2009 03:49:17 -0700 (PDT) [thread overview]
Message-ID: <20091007.034917.68739080.davem@davemloft.net> (raw)
In-Reply-To: <20091007.034425.54165326.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 07 Oct 2009 03:44:25 -0700 (PDT)
> From: Wolfgang Grandegger <wg@grandegger.com>
> Date: Wed, 07 Oct 2009 09:15:24 +0200
>
>> Anant Gole wrote:
>>> TI HECC (High End CAN Controller) module is found on many TI devices. It
>>> has 32 hardware mailboxes with full implementation of CAN protocol 2.0B
>>> with bus speeds up to 1Mbps. Specifications of the module are available
>>> on TI web <http://www.ti.com>
>>>
>>> Signed-off-by: Anant Gole <anantgole@ti.com>
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>
>> Thanks for your contribution.
>
> Applied, thanks everyone.
Actually I have to revert this.
You have to add restrictions to the Kconfig entry for this
driver so that it only builds where the necessary interfaces
exist.
Otherwise it will fail to link on non-ARM platforms because
they lack the clk_*() functions this driver uses.
prev parent reply other threads:[~2009-10-07 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 5:15 [net-next-2.6 PATCH V2] can: add TI CAN (HECC) driver Anant Gole
[not found] ` <1254892544-28194-1-git-send-email-anantgole-l0cyMroinI0@public.gmane.org>
2009-10-07 7:15 ` Wolfgang Grandegger
2009-10-07 10:44 ` David Miller
2009-10-07 10:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007.034917.68739080.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anantgole@ti.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).