From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@free.fr
Cc: fubar@us.ibm.com, netdev@vger.kernel.org,
bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH netnext-2.6] bonding: remove useless assignment
Date: Wed, 07 Oct 2009 14:11:15 -0700 (PDT) [thread overview]
Message-ID: <20091007.141115.101755919.davem@davemloft.net> (raw)
In-Reply-To: <1254949168-12404-2-git-send-email-nicolas.2p.debian@free.fr>
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Wed, 7 Oct 2009 22:59:28 +0200
> The variable old_active is first set to bond->curr_active_slave.
> Then, it is unconditionally set to new_active, without being used in between.
>
> The first assignment, having no side effect, is useless.
>
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
> Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Also applied.
Conclusion, avoid Thunderbird like the plague....
next prev parent reply other threads:[~2009-10-07 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 20:59 [PATCH netnext-2.6] bonding: fix a parameter name in error message Nicolas de Pesloüan
2009-10-07 20:59 ` [PATCH netnext-2.6] bonding: remove useless assignment Nicolas de Pesloüan
2009-10-07 21:11 ` David Miller [this message]
2009-10-07 21:10 ` [PATCH netnext-2.6] bonding: fix a parameter name in error message David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007.141115.101755919.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).