From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: atis@mikrotik.com, netdev@vger.kernel.org, panther@balabit.hu,
eric.dumazet@gmail.com, brian.haley@hp.com
Subject: Re: [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding
Date: Wed, 07 Oct 2009 22:39:28 -0700 (PDT) [thread overview]
Message-ID: <20091007.223928.34412707.davem@davemloft.net> (raw)
In-Reply-To: <55a4f86e0910071703i4735f1aan1ddba81eec7eef19@mail.gmail.com>
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Wed, 7 Oct 2009 17:03:30 -0700
> Should wrapping a packet into a tunnel clear the mark?
> Should perhaps the mark be a parameter of the tunnel (like ttl or qos,
> can be set or can be inherited)?
That's the big question.
It may be that the only logical thing we can do is only apply
the socket mark to the top-level path and that's what happens
now.
Because we really don't have any reasonable way to let the user
control where it applies. We have no way for it to say "don't
apply the mark to the top-level path, but do apply it to the
multicast tunnel' or something like that.
So, to be honest, I'd say we should skip these skb->mark cases
for now.
next prev parent reply other threads:[~2009-10-08 5:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 13:46 [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding Atis Elsts
2009-10-07 10:19 ` David Miller
2009-10-07 12:59 ` Atis Elsts
2009-10-07 20:56 ` David Miller
2009-10-08 0:03 ` Maciej Żenczykowski
2009-10-08 5:39 ` David Miller [this message]
2009-10-14 7:51 ` Maciej Żenczykowski
2009-10-14 7:23 ` steve
2009-10-14 9:15 ` David Miller
2009-10-14 9:50 ` Maciej Żenczykowski
2009-10-14 9:27 ` steve
2009-10-14 11:04 ` Atis Elsts
2009-10-14 10:16 ` steve
2009-10-14 18:33 ` Maciej Żenczykowski
2009-10-19 8:20 ` steve
2009-10-19 11:38 ` Atis Elsts
2009-10-08 13:19 ` [PATCH] net: Use routing mark from skb in multicast forwarding routing lookups Atis Elsts
2009-10-13 10:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007.223928.34412707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atis@mikrotik.com \
--cc=brian.haley@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).