From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, stefano.babic@babic.homelinux.org,
randy.dunlap@oracle.com, kim.xx.lilliestierna@stericsson.com,
christian.bejram@stericsson.com,
daniel.martensson@stericsson.com
Subject: Re: [PATCH] [CAIF-RFC 0/8-v2] CAIF Protocol Stack
Date: Mon, 12 Oct 2009 02:41:49 -0700 (PDT) [thread overview]
Message-ID: <20091012.024149.61074790.davem@davemloft.net> (raw)
In-Reply-To: <1255095571-6501-1-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Fri, 09 Oct 2009 15:39:23 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> This is the second version of the CAIF patch set.
> The patch set is compiled on 386 for 2.6.31.
> All feedback is apreciated.
There is a lot of coding style issues here I'd like you to
address in your next submission.
Comments are formatted in several places like this:
/*
*
*
*/
It should be:
/*
*
*
*/
Also often there are tons of extraneous empty lines in the source
files. Particularly right after the comment at the top of the
source file. For example include/net/caif/generic/cfcnfg.h
there is the top comment (which needs to be fixed as described
above) and then 8 empty lines before the #ifndef CFCNFG_H_
That's rediculious, just have one empty line there seperating things.
Seriously, you should be able to just scan over your patch and see all
of these oddities. They jumped right out at me. Please clean them
up.
Thank you.
prev parent reply other threads:[~2009-10-12 9:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 13:39 [PATCH] [CAIF-RFC 0/8-v2] CAIF Protocol Stack sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 1/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 2/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 3/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 4/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 5/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 6/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 7/8-v2] " sjur.brandeland
2009-10-09 13:39 ` [PATCH] [CAIF-RFC 8/8-v2] " sjur.brandeland
2009-10-12 13:43 ` [PATCH] [CAIF-RFC 7/8-v2] " Stefano Babic
2009-10-12 13:06 ` [PATCH] [CAIF-RFC 6/8-v2] " Stefano Babic
2009-10-09 16:43 ` [PATCH] [CAIF-RFC 5/8-v2] " Randy Dunlap
2009-10-12 12:51 ` Stefano Babic
2009-10-12 12:20 ` [PATCH] [CAIF-RFC 4/8-v2] " Stefano Babic
2009-10-12 9:28 ` [PATCH] [CAIF-RFC 2/8-v2] " Stefano Babic
2009-10-12 8:08 ` [PATCH] [CAIF-RFC 1/8-v2] " Stefano Babic
2009-10-12 8:20 ` David Miller
2009-10-12 9:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012.024149.61074790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christian.bejram@stericsson.com \
--cc=daniel.martensson@stericsson.com \
--cc=kim.xx.lilliestierna@stericsson.com \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sjur.brandeland@stericsson.com \
--cc=stefano.babic@babic.homelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).