netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
	skraw@ithnet.com, netdev@vger.kernel.org,
	jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
	peter.p.waskiewicz.jr@intel.com
Subject: Re: [Bug #14252] WARNING: at include/linux/skbuff.h:1382 w/ e1000
Date: Mon, 12 Oct 2009 03:49:19 -0700 (PDT)	[thread overview]
Message-ID: <20091012.034919.98011643.davem@davemloft.net> (raw)
In-Reply-To: <L6tb-VyKHZK.A.9UD.zzl0KB@chimera>

From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Mon, 12 Oct 2009 01:01:06 +0200 (CEST)

> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.30 and 2.6.31.
> 
> The following bug entry is on the current list of known regressions
> introduced between 2.6.30 and 2.6.31.  Please verify if it still should
> be listed and let me know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14252
> Subject		: WARNING: at include/linux/skbuff.h:1382 w/ e1000
> Submitter	: Stephan von Krawczynski <skraw@ithnet.com>
> Date		: 2009-09-20 11:26 (22 days old)
> References	: http://marc.info/?l=linux-kernel&m=125344599006033&w=4

Hmmm... e1000 calls skb_trim() on both jumbo and non-jumbo ring
buffers which get recycled.

At least for the Jumbo case, that's illegal as you cannot call
skb_trim() on an SKB with paged data.

But this assertion is triggering for the non-jumbo ring where
only linear packets should be present as far as I can tell.

Some Intel folks need to take a look, CC:'d, and people need
to CC: their networking bug reports to netdev@vger.kernel.org
so that the proper folks see it.

Thanks.

  parent reply	other threads:[~2009-10-12 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 22:41 2.6.32-rc4: Reported regressions 2.6.30 -> 2.6.31 Rafael J. Wysocki
2009-10-11 23:24 ` Larry Finger
2009-10-12 21:43   ` Rafael J. Wysocki
     [not found] ` <L6tb-VyKHZK.A.9UD.zzl0KB@chimera>
2009-10-12 10:49   ` David Miller [this message]
2009-10-12 11:44     ` [Bug #14252] WARNING: at include/linux/skbuff.h:1382 w/ e1000 Stephan von Krawczynski
     [not found] ` <L6tb-VyKHZK.A.YoC.lzl0KB@chimera>
2009-10-12 11:05   ` [Bug #14265] ifconfig: page allocation failure. order:5, mode:0x8020 w/ e100 David Miller
2009-10-13 12:29     ` Karol Lewandowski
2009-10-12 12:22 ` 2.6.32-rc4: Reported regressions 2.6.30 -> 2.6.31 Frederik Deweerdt
2009-10-12 21:46   ` Rafael J. Wysocki
2009-10-12 19:58 ` Andrew Patterson
2009-10-12 21:48   ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2009-11-16 22:58 2.6.32-rc7-git1: " Rafael J. Wysocki
     [not found] ` <OWmO9uyC1hM.A.w9C.NodALB@chimera>
2009-11-19 20:07   ` [Bug #14252] WARNING: at include/linux/skbuff.h:1382 w/ e1000 David Miller
     [not found]     ` <20091119.120721.252464351.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-11-23 18:02       ` Tantilov, Emil S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091012.034919.98011643.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=rjw@sisk.pl \
    --cc=skraw@ithnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).