From: David Miller <davem@davemloft.net>
To: rakib.mullick@gmail.com
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org,
zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] connector: Passing required parameter for function cn_add_callback.
Date: Mon, 12 Oct 2009 23:42:14 -0700 (PDT) [thread overview]
Message-ID: <20091012.234214.110950674.davem@davemloft.net> (raw)
In-Reply-To: <b9df5fa10910122227r710d6782m89fc9ec4273487b8@mail.gmail.com>
From: Rakib Mullick <rakib.mullick@gmail.com>
Date: Tue, 13 Oct 2009 11:27:49 +0600
> On 10/12/09, David Miller <davem@davemloft.net> wrote:
>> From: Rakib Mullick <rakib.mullick@gmail.com>
>> Date: Mon, 12 Oct 2009 08:44:33 +0600
>>
>>
>> > */
>> > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
>> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
>> > netlink_skb_parms *nsp)
>>
>>
>> Your patches are unusable because your email client corrupts the
>> patch, here you can see it is splitting up long lines.
>>
>> Please fix this up and resubmit.
> Oops..... sorry for that. This is the second time I'm facing this
> problem. I'll try to fix it.
> I'm resubmitting the patch. Here I've recreate the patch to split the
> line into two.
> And it just reaches its 80 line mark. Hopefully it will be okay.
Upstream and my net-next-2.6 tree both have this function with
the proper parameters, maybe Andrew's -mm tree had some conflicts
and they weren't dealt with correctly.
next prev parent reply other threads:[~2009-10-13 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 2:44 [PATCH -mm] connector: Passing required parameter for function cn_add_callback Rakib Mullick
2009-10-12 5:35 ` David Miller
2009-10-13 5:27 ` Rakib Mullick
2009-10-13 6:42 ` David Miller [this message]
2009-10-13 7:00 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012.234214.110950674.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox