From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 0/8] gianfar: Add support for hibernation Date: Mon, 12 Oct 2009 23:57:47 -0700 (PDT) Message-ID: <20091012.235747.195783342.davem@davemloft.net> References: <20091012160000.GA32406@oksana.dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: scottwood@freescale.com, linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, afleming@freescale.com To: avorontsov@ru.mvista.com Return-path: In-Reply-To: <20091012160000.GA32406@oksana.dev.rtsoft.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: netdev.vger.kernel.org From: Anton Vorontsov Date: Mon, 12 Oct 2009 20:00:00 +0400 > Here are few patches that add support for hibernation for gianfar > driver. > > Technically, we could just do gfar_close() and then gfar_enet_open() > sequence to restore gianfar functionality after hibernation, but > close/open does so many unneeded things (e.g. BDs buffers freeing and > allocation, IRQ freeing and requesting), that I felt it would be much > better to cleanup and refactor some code to make the hibernation [and > not only hibernation] code a little bit prettier. I applied all of this, it's a really nice patch set. If there are any problems we can deal with it using follow-on fixups. I noticed something, in patch #3 where you remove the spurious wrap bit setting in startup_gfar(). It looks like that was not only spurious but it was doing it wrong too. It's writing garbage into the status word, because it's not using the BD_LFLAG() macro to shift the value up 16 bits.