Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gombasg@sztaki.hu
Cc: netdev@vger.kernel.org, johann.baudy@gnu-log.net
Subject: Re: [PATCH] Re: PACKET_TX_RING: packet size is too long
Date: Tue, 13 Oct 2009 00:54:38 -0700 (PDT)	[thread overview]
Message-ID: <20091013.005438.32630424.davem@davemloft.net> (raw)
In-Reply-To: <20091009220546.GB7618@boogie.lpds.sztaki.hu>

From: Gabor Gombas <gombasg@sztaki.hu>
Date: Sat, 10 Oct 2009 00:05:46 +0200

> Hi,
> 
> Digging list archives I suspect the current value of size_max is the
> remnant of the zero-copy mode that was not merged. So I propose the
> following patch that IMHO makes the value of size_max consistent with
> how the frame is actually handled in tpacket_fill_skb().
> 
> If the zero-copy mode is ever to be resurrected, then the user should
> explicitely request it, and either the length of the extra padding
> should be the same for 32-bit and 64-bit kernels or there must be a way
> to query the value at run time.

Johann, please take a look at this.

Gabor, please resubmit your patch with a proper Signed-off-by:
tag so I can apply it if it is correct.

Thanks.

  reply	other threads:[~2009-10-13  7:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09  9:07 PACKET_TX_RING: packet size is too long Gabor Gombas
2009-10-09 22:05 ` [PATCH] " Gabor Gombas
2009-10-13  7:54   ` David Miller [this message]
2009-10-15 20:10     ` Gabor Gombas
2009-10-29 10:19       ` David Miller
2009-10-29 10:29         ` Gabor Gombas
2009-10-29 10:40           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013.005438.32630424.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gombasg@sztaki.hu \
    --cc=johann.baudy@gnu-log.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox