From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
Ralf.Hildebrandt-jq1tPX9l7E6ELgA04lAiVw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yjwei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org,
tyasui-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
haoki-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] udp: Fix udp_poll() and ioctl()
Date: Tue, 13 Oct 2009 03:18:14 -0700 (PDT) [thread overview]
Message-ID: <20091013.031814.100807531.davem@davemloft.net> (raw)
In-Reply-To: <4ACF4C1C.4050505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Fri, 09 Oct 2009 16:43:40 +0200
> [PATCH] udp: Fix udp_poll()
>
> udp_poll() can in some circumstances drop frames with incorrect checksums.
>
> Problem is we now have to lock the socket while dropping frames, or risk
> sk_forward corruption.
>
> This bug is present since commit 95766fff6b9a78d1
> ([UDP]: Add memory accounting.)
>
> While we are at it, we can correct ioctl(SIOCINQ) to also drop bad frames.
>
> Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Looks good, applied, thanks Eric!
prev parent reply other threads:[~2009-10-13 10:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 19:53 2.6.32-rc1-git2: Reported regressions 2.6.30 -> 2.6.31 Rafael J. Wysocki
[not found] ` <COE24pZSBH.A.jd.5MTxKB@chimera>
[not found] ` <877hvd8rj5.fsf@spindle.srvr.nix>
[not found] ` <877hvd8rj5.fsf-AdTWujXS48Mg67Zj9sPl2A@public.gmane.org>
2009-10-02 21:31 ` [Bug #14261] e1000e jumbo frames no longer work: 'Unsupported MTU setting' Rafael J. Wysocki
2009-10-02 22:13 ` Jeff Kirsher
2009-10-07 18:34 ` Theodore Tso
2009-10-07 19:12 ` Jeff Kirsher
[not found] ` <COE24pZSBH.A.mdH.sMTxKB@chimera>
2009-10-03 8:36 ` [Bug #14301] WARNING: at net/ipv4/af_inet.c:154 Eric Dumazet
[not found] ` <4AC70D20.4060009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-03 8:52 ` Eric Dumazet
2009-10-03 17:53 ` Eric Dumazet
[not found] ` <4AC78F7C.40908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-07 15:41 ` Eric Dumazet
2009-10-09 14:43 ` [PATCH] udp: Fix udp_poll() and ioctl() Eric Dumazet
[not found] ` <4ACF4C1C.4050505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-13 10:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013.031814.100807531.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=Ralf.Hildebrandt-jq1tPX9l7E6ELgA04lAiVw@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=haoki-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=tyasui-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=yjwei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).