From: David Miller <davem@davemloft.net>
To: steve@chygwyn.com
Cc: zenczykowski@gmail.com, atis@mikrotik.com,
netdev@vger.kernel.org, panther@balabit.hu,
eric.dumazet@gmail.com, brian.haley@hp.com
Subject: Re: [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding
Date: Wed, 14 Oct 2009 02:15:05 -0700 (PDT) [thread overview]
Message-ID: <20091014.021505.181431380.davem@davemloft.net> (raw)
In-Reply-To: <20091014072319.GA12095@fogou.chygwyn.com>
From: steve@chygwyn.com
Date: Wed, 14 Oct 2009 08:23:19 +0100
> On Wed, Oct 14, 2009 at 12:51:56AM -0700, Maciej Żenczykowski wrote:
>> I'm thinking that the mark should be a tunnel parameter with values of
>> inherit or a constant.
>>
> Why not do this on a per-route basis (i.e. lets suppose we add a
> "setmark" parameter to each route) and this would allow changing
> a mark when a packet matches the route. This not only solves the
> tunnel case, but would be generically useful as well.
>
> Since we have to look up routes anyway, it shouldn't add any
> real overhead to the routing process and we can benefit from
> all the existing infrastructure (route cache, etc).
This idea, I like :-)
next prev parent reply other threads:[~2009-10-14 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 13:46 [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding Atis Elsts
2009-10-07 10:19 ` David Miller
2009-10-07 12:59 ` Atis Elsts
2009-10-07 20:56 ` David Miller
2009-10-08 0:03 ` Maciej Żenczykowski
2009-10-08 5:39 ` David Miller
2009-10-14 7:51 ` Maciej Żenczykowski
2009-10-14 7:23 ` steve
2009-10-14 9:15 ` David Miller [this message]
2009-10-14 9:50 ` Maciej Żenczykowski
2009-10-14 9:27 ` steve
2009-10-14 11:04 ` Atis Elsts
2009-10-14 10:16 ` steve
2009-10-14 18:33 ` Maciej Żenczykowski
2009-10-19 8:20 ` steve
2009-10-19 11:38 ` Atis Elsts
2009-10-08 13:19 ` [PATCH] net: Use routing mark from skb in multicast forwarding routing lookups Atis Elsts
2009-10-13 10:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014.021505.181431380.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atis@mikrotik.com \
--cc=brian.haley@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
--cc=steve@chygwyn.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).