[net-next 0/8] bnx2x: Device Control Channel bug fixes

[net-next 0/8] bnx2x: Device Control Channel bug fixes

[Eilon Greenstein]

Hi Dave,

This bnx2x patch series is fixing some bugs that relates to the Device
Control Channel (DCC) code. There are actually 3 different failures:

1. When the fairness initial value was set to zero, the device could not
be enabled. This is caused since zero indicated that the mechanism is
disabled, and the code (both FW and driver) was not ready to allow
enabling it at run time. This patch requires replacing the FW - to allow
easier review, it is split to 3 patches:
        P1: adding the new FW
        P2: the actually patch
        P3: removing the old FW
        
2. Races when loading/unloading the driver when DCC link enable/disable
commands are received. There were 3 different races:
        P4: The state of the driver which indicates if it is loaded or
        not was also used to signal if its link is enabled/disabled by
        DCC
        P5: The FW commands to acknowledge the DCC command and
        loading/unloading the driver run over each other
        P6: Setting/clearing the MAC address and the FW filtering rules
        
3.	P7: Reporting the maximal BW as the link speed

Patch number 8 is the version update.

The patches were made based on net-next. Since those are bug fixes,
please let me know if I should send them based on net-2.6 as well.

Thanks,
Eilon

Re: [net-next 0/8] bnx2x: Device Control Channel bug fixes

[David Miller]

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Wed, 14 Oct 2009 17:07:05 +0200

> This bnx2x patch series is fixing some bugs that relates to the Device
> Control Channel (DCC) code. There are actually 3 different failures:
> 
> 1. When the fairness initial value was set to zero, the device could not
> be enabled. This is caused since zero indicated that the mechanism is
> disabled, and the code (both FW and driver) was not ready to allow
> enabling it at run time. This patch requires replacing the FW - to allow
> easier review, it is split to 3 patches:
>         P1: adding the new FW
>         P2: the actually patch
>         P3: removing the old FW
>         
> 2. Races when loading/unloading the driver when DCC link enable/disable
> commands are received. There were 3 different races:
>         P4: The state of the driver which indicates if it is loaded or
>         not was also used to signal if its link is enabled/disabled by
>         DCC
>         P5: The FW commands to acknowledge the DCC command and
>         loading/unloading the driver run over each other
>         P6: Setting/clearing the MAC address and the FW filtering rules
>         
> 3.	P7: Reporting the maximal BW as the link speed
> 
> Patch number 8 is the version update.
> 
> The patches were made based on net-next. Since those are bug fixes,
> please let me know if I should send them based on net-2.6 as well.

Applied to net-next-2.6, which is where this likely belongs.

Thanks!

Re: [net-next 0/8] bnx2x: Device Control Channel bug fixes

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Wed, 14 Oct 2009 15:09:22 -0700 (PDT)

> Applied to net-next-2.6, which is where this likely belongs.

Eilon I somehow screwed up this patch set, and largely that is
because the firmware patch was too large for the list and therefore
it didn't end up in patchwork.

I tried to force in the private copy you sent me into the bundle
I applied, but I screwed that up somehow.

Could you please privately send me this whole patch set again so I can
try to apply it properly?

Thanks!

Re: [net-next 0/8] bnx2x: Device Control Channel bug fixes

[Eilon Greenstein]

On Wed, 2009-10-14 at 16:57 -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 14 Oct 2009 15:09:22 -0700 (PDT)
> 
> > Applied to net-next-2.6, which is where this likely belongs.
> 
> Eilon I somehow screwed up this patch set, and largely that is
> because the firmware patch was too large for the list and therefore
> it didn't end up in patchwork.
> 
> I tried to force in the private copy you sent me into the bundle
> I applied, but I screwed that up somehow.
> 
> Could you please privately send me this whole patch set again so I can
> try to apply it properly?
> 
> Thanks!
> 
Coming right up! Just in case it helps in any way, here is a link to the
patches: http://linux.broadcom.com/eilong/

Thanks,
Eilon

Re: [net-next 0/8] bnx2x: Device Control Channel bug fixes

[David Miller]

From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Thu, 15 Oct 2009 08:47:51 +0200

> On Wed, 2009-10-14 at 16:57 -0700, David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Wed, 14 Oct 2009 15:09:22 -0700 (PDT)
>> 
>> > Applied to net-next-2.6, which is where this likely belongs.
>> 
>> Eilon I somehow screwed up this patch set, and largely that is
>> because the firmware patch was too large for the list and therefore
>> it didn't end up in patchwork.
>> 
>> I tried to force in the private copy you sent me into the bundle
>> I applied, but I screwed that up somehow.
>> 
>> Could you please privately send me this whole patch set again so I can
>> try to apply it properly?
>> 
>> Thanks!
>> 
> Coming right up! Just in case it helps in any way, here is a link to the
> patches: http://linux.broadcom.com/eilong/

Applied and pushed out to net-next-2.6, thank you.