From: Atis Elsts <atis@mikrotik.com>
To: steve@chygwyn.com
Cc: "Maciej Żenczykowski" <zenczykowski@gmail.com>,
"David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, panther@balabit.hu,
eric.dumazet@gmail.com, brian.haley@hp.com
Subject: Re: [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding
Date: Wed, 14 Oct 2009 14:04:37 +0300 [thread overview]
Message-ID: <200910141404.37882.atis@mikrotik.com> (raw)
In-Reply-To: <20091014092743.GA13374@fogou.chygwyn.com>
On Wednesday 14 October 2009 12:27:43 steve@chygwyn.com wrote:
>
> The mark is supposed to be a generic thing, not just for routing
> lookups, it can be used for classification, etc as well.
In general, sounds like a good idea, but IMHO exactly this could be a problem.
skb->mark is already used for a lot of things. What if I am setting the mark
by a firewall rule in prerouting chain, and matching it by a postrouting
rule? If routing lookup was changing the mark, then my setup would break.
Perhaps one more field could be added dst_entry? The field would be filled
from route's table (if "setmark" for that route was specified). The use of
that field would be similar to tclassid (e.g matching in firewall), except
that it would also be used in routing lookups, if set.
> I would
> expect to see such a thing used for maybe specifying a VLAN or
> a reference to an MPLS label stack, or something similar too,
>
> Steve.
next prev parent reply other threads:[~2009-10-14 11:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 13:46 [PATCH] Add sk_mark route lookup support for IPv4 listening sockets, and for IPv4 multicast forwarding Atis Elsts
2009-10-07 10:19 ` David Miller
2009-10-07 12:59 ` Atis Elsts
2009-10-07 20:56 ` David Miller
2009-10-08 0:03 ` Maciej Żenczykowski
2009-10-08 5:39 ` David Miller
2009-10-14 7:51 ` Maciej Żenczykowski
2009-10-14 7:23 ` steve
2009-10-14 9:15 ` David Miller
2009-10-14 9:50 ` Maciej Żenczykowski
2009-10-14 9:27 ` steve
2009-10-14 11:04 ` Atis Elsts [this message]
2009-10-14 10:16 ` steve
2009-10-14 18:33 ` Maciej Żenczykowski
2009-10-19 8:20 ` steve
2009-10-19 11:38 ` Atis Elsts
2009-10-08 13:19 ` [PATCH] net: Use routing mark from skb in multicast forwarding routing lookups Atis Elsts
2009-10-13 10:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910141404.37882.atis@mikrotik.com \
--to=atis@mikrotik.com \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
--cc=steve@chygwyn.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).