From: Octavian Purdila <opurdila@ixiacom.com>
To: David Miller <davem@davemloft.net>
Cc: cratiu@ixiacom.com, jin.dongming@np.css.fujitsu.com,
kaneshige.kenji@jp.fujitsu.com, seto.hidetoshi@jp.fujitsu.com,
netdev@vger.kernel.org
Subject: Re: [Patch-next] Fix the size overflow of addrconf_sysctl array
Date: Wed, 14 Oct 2009 21:14:48 +0300 [thread overview]
Message-ID: <200910142114.53845.opurdila@ixiacom.com> (raw)
In-Reply-To: <20091013.034509.130893738.davem@davemloft.net>
On Tuesday 13 October 2009 13:45:09 you wrote:
> From: Cosmin Ratiu <cratiu@ixiacom.com>
> Date: Fri, 9 Oct 2009 16:11:14 +0300
>
> > Shouldn't this be changed too then?
> >
> > Or better yet, wouldn't a change that eliminates the need of adding a new
> > option in two separate places be useful?
>
> Yes, it's crummy how things work now, indeed.
>
> > I see the only use for that DEVCONF enum is to dump the settings via
> > netlink. Wouldn't a memcpy suffice?
>
> It should be.
>
I've taken a look at this and it seems the current way of doing it is really
required as we need to preserve userspace ABI across different CONFIG_
settings.
tavi
prev parent reply other threads:[~2009-10-14 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4ACEA207.7010208@np.css.fujitsu.com>
2009-10-09 5:44 ` [Patch-next] Fix the size overflow of addrconf_sysctl array David Miller
2009-10-09 13:11 ` Cosmin Ratiu
2009-10-13 10:45 ` David Miller
2009-10-14 18:14 ` Octavian Purdila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910142114.53845.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=cratiu@ixiacom.com \
--cc=davem@davemloft.net \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox