From: Ajit Khaparde <ajitkhaparde@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH 1/2] be2net: Add support for next generation of BladeEngine device
Date: Thu, 15 Oct 2009 09:19:01 +0530 [thread overview]
Message-ID: <20091015034858.GB10799@serverengines.com> (raw)
In-Reply-To: <20091014.163345.28372235.davem@davemloft.net>
On 14/10/09 16:33 -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 14 Oct 2009 15:24:02 -0700 (PDT)
>
> > From: Ajit Khaparde <ajitk@serverengines.com>
> > Date: Wed, 14 Oct 2009 17:54:09 +0530
> >
> >> Add new PCI ids to support next generation of BladeEnigne device.
> >>
> >> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
> >
> > Applied.
>
> I have to revert your changes, how did this even build for you?
>
> In file included from drivers/net/benet/be_cmds.c:18:
> drivers/net/benet/be.h:45:1: warning: "BE_DEVICE_ID1" redefined
> drivers/net/benet/be.h:44:1: warning: this is the location of the previous definition
> drivers/net/benet/be.h:48:1: warning: "OC_DEVICE_ID2" redefined
> drivers/net/benet/be.h:47:1: warning: this is the location of the previous definition
>
> Well, obviously, since in your patch:
>
> #define BE_VENDOR_ID 0x19a2
> #define BE_DEVICE_ID1 0x211
> +#define BE_DEVICE_ID1 0x221
> #define OC_DEVICE_ID1 0x700
> #define OC_DEVICE_ID2 0x701
> +#define OC_DEVICE_ID2 0x710
>
> drivers/net/benet/be.h:56: error: 'OC_DEVICE_ID3' undeclared (first use in this function)
> drivers/net/benet/be.h:58: error: 'BE_DEVICE_ID2' undeclared (first use in this function)
>
> The mistake is obvious, and you provably didn't even compile check
> these changes.
>
> How can I possibly take your patches seriously when it is clear how
> incredibly careless you are being here?
Sorry Dave. My bad. Now I realize what happened.
After I compiled and tried my changes, the setup got rebooted and I picked
the files from a wrong sandbox. And these wrong files got committed to git.
I will be careful next time.
prev parent reply other threads:[~2009-10-15 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 12:24 [net-next-2.6 PATCH 1/2] be2net: Add support for next generation of BladeEngine device Ajit Khaparde
2009-10-14 22:24 ` David Miller
2009-10-14 23:33 ` David Miller
2009-10-15 3:49 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015034858.GB10799@serverengines.com \
--to=ajitkhaparde@gmail.com \
--cc=ajitk@serverengines.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox