Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dhananjay@netxen.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH NEXT 1/7] netxen; update version to 4.0.56
Date: Fri, 16 Oct 2009 17:56:21 -0700 (PDT)	[thread overview]
Message-ID: <20091016.175621.76312736.davem@davemloft.net> (raw)
In-Reply-To: <1255673353-31797-2-git-send-email-dhananjay@netxen.com>

From: Dhananjay Phadke <dhananjay@netxen.com>
Date: Thu, 15 Oct 2009 23:09:07 -0700

> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>

This doesn't make any sense at all.

You should update the driver version _AFTER_ your set
of changes, not before.

I have never in my entire life seen someone bump the
driver version before the actual changes.

Please respin this properly, thanks.

  reply	other threads:[~2009-10-17  0:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16  6:09 [PATCH NEXT 0/7] netxen: changes for future chip revisions Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 1/7] netxen; update version to 4.0.56 Dhananjay Phadke
2009-10-17  0:56   ` David Miller [this message]
2009-10-17  1:15     ` Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 2/7] netxen: defines for next revision Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 3/7] netxen: 128 memory controller support Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 4/7] netxen: reset sequence changes Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 5/7] netxen: onchip memory access change Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 6/7] netxen: fix error codes in for tools access Dhananjay Phadke
2009-10-16  6:09 ` [PATCH NEXT 7/7] netxen: sysfs control for auto firmware recovery Dhananjay Phadke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091016.175621.76312736.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dhananjay@netxen.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox