* [PATCH] fix section mismatch in fec.c
@ 2009-10-18 22:25 Steven King
2009-10-19 4:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steven King @ 2009-10-18 22:25 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
fec_enet_init is called by both fec_probe and fec_resume, so it shouldn't
be marked as __init.
Signed-off-by: Steven King <sfking@fdwdc.com>
diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 2923438..e8218a3 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1654,7 +1654,8 @@ static const struct net_device_ops fec_netdev_ops = {
*
* index is only used in legacy code
*/
-int __init fec_enet_init(struct net_device *dev, int index)
+static int
+fec_enet_init(struct net_device *dev, int index)
{
struct fec_enet_private *fep = netdev_priv(dev);
struct bufdesc *cbd_base;
--
Steven King -- sfking at fdwdc dot com
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix section mismatch in fec.c
2009-10-18 22:25 [PATCH] fix section mismatch in fec.c Steven King
@ 2009-10-19 4:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-19 4:27 UTC (permalink / raw)
To: sfking; +Cc: linux-kernel, netdev
From: Steven King <sfking@fdwdc.com>
Date: Sun, 18 Oct 2009 15:25:48 -0700
> */
> -int __init fec_enet_init(struct net_device *dev, int index)
> +static int
> +fec_enet_init(struct net_device *dev, int index)
> {
Don't change coding style when fixing a bug.
Fix this up and resubmit your fix, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-19 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-18 22:25 [PATCH] fix section mismatch in fec.c Steven King
2009-10-19 4:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).