From: David Miller <davem@davemloft.net>
To: wg@grandegger.com
Cc: netdev@vger.kernel.org, socketcan-core@lists.berlios.de,
haas@ems-wuensche.com, anantgole@ti.com, mkl@pengutronix.de
Subject: Re: [PATCH v2] can: provide library functions for skb allocation
Date: Mon, 19 Oct 2009 23:05:49 -0700 (PDT) [thread overview]
Message-ID: <20091019.230549.29520350.davem@davemloft.net> (raw)
In-Reply-To: <20091019.215440.256002623.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 19 Oct 2009 21:54:40 -0700 (PDT)
> Applied, thanks.
Actually I have to back this out, you have to add an extern
declaration for these public functions to a header the CAN
drivers will see, or else there'll be build warnings and
errors.
I wonder if you actually did this, but forgot that part of
the change or lost it somehow while respinning this.
Please fix this up and resubmit, thanks.
next prev parent reply other threads:[~2009-10-20 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 18:45 [PATCH v2] can: provide library functions for skb allocation Wolfgang Grandegger
2009-10-20 4:54 ` David Miller
2009-10-20 6:05 ` David Miller [this message]
[not found] ` <20091019.230549.29520350.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-10-20 6:43 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019.230549.29520350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anantgole@ti.com \
--cc=haas@ems-wuensche.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).