From: Ben Dooks <ben@simtec.co.uk>
To: netdev@vger.kernel.org
Cc: Ping.Doong@Micrel.Com
Subject: [patch 1/3] KS8851: Add soft reset at probe time
Date: Tue, 20 Oct 2009 10:49:03 +0100 [thread overview]
Message-ID: <20091020094954.310595275@fluff.org.uk> (raw)
In-Reply-To: 20091020094902.274646871@fluff.org.uk
[-- Attachment #1: ks8851-reset-at-probe.patch --]
[-- Type: text/plain, Size: 984 bytes --]
Issue a full soft reset at probe time.
This was reported by Doong Ping of Micrel, but no explanation of why this
is necessary or what bug it is fixing. Add it as it does not seem to hurt
the current driver and ensures that the device is in a known state when we
start setting it up.
Signed-off-by: Ben Dooks <ben@simtec.co.uk>
---
drivers/net/ks8851.c | 3 +++
1 file changed, 3 insertions(+)
Index: b/drivers/net/ks8851.c
===================================================================
--- a/drivers/net/ks8851.c 2009-10-12 23:04:15.000000000 +0100
+++ b/drivers/net/ks8851.c 2009-10-13 13:28:43.000000000 +0100
@@ -1239,6 +1239,9 @@ static int __devinit ks8851_probe(struct
ndev->netdev_ops = &ks8851_netdev_ops;
ndev->irq = spi->irq;
+ /* issue a global soft reset to reset the device. */
+ ks8851_soft_reset(ks, GRR_GSR);
+
/* simple check for a valid chip being connected to the bus */
if ((ks8851_rdreg16(ks, KS_CIDER) & ~CIDER_REV_MASK) != CIDER_ID) {
next prev parent reply other threads:[~2009-10-20 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 9:49 [patch 0/3] KS8851 updates for -rc5 Ben Dooks
2009-10-20 9:49 ` Ben Dooks [this message]
2009-10-20 9:49 ` [patch 2/3] KS8851: Fix MAC address write order Ben Dooks
2009-10-20 9:49 ` [patch 3/3] KS8851: Fix ks8851_set_rx_mode() for IFF_MULTICAST Ben Dooks
2009-10-20 17:53 ` [patch 0/3] KS8851 updates for -rc5 Doong, Ping
2009-10-20 22:26 ` Ben Dooks
2009-10-21 2:11 ` David Miller
2009-10-21 2:12 ` David Miller
2009-10-21 10:44 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020094954.310595275@fluff.org.uk \
--to=ben@simtec.co.uk \
--cc=Ping.Doong@Micrel.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).