From: David Miller <davem@davemloft.net>
To: arjan@infradead.org
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] net: use WARN() for the WARN_ON in commit b6b39e8f3fbbb
Date: Thu, 22 Oct 2009 21:38:12 -0700 (PDT) [thread overview]
Message-ID: <20091022.213812.83606333.davem@davemloft.net> (raw)
In-Reply-To: <20091022203512.1d714d5a@infradead.org>
From: Arjan van de Ven <arjan@infradead.org>
Date: Thu, 22 Oct 2009 20:35:12 -0700
> Commit b6b39e8f3fbbb (tcp: Try to catch MSG_PEEK bug) added a printk()
> to the WARN_ON() that's in tcp.c. This patch changes this combination
> to WARN(); the advantage of WARN() is that the printk message shows up
> inside the message, so that kerneloops.org will collect the message.
>
> In addition, this gets rid of an extra if() statement.
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2009-10-23 4:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 3:35 [PATCH] net: use WARN() for the WARN_ON in commit b6b39e8f3fbbb Arjan van de Ven
2009-10-23 4:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022.213812.83606333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjan@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).