From: Cyrill Gorcunov <gorcunov@gmail.com>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC] net,socket: introduce build_sockaddr_check helper to catch overflow at build time
Date: Sat, 24 Oct 2009 01:43:06 +0400 [thread overview]
Message-ID: <20091023214306.GA30616@lenovo> (raw)
In-Reply-To: <20091022135557.GA5162@lenovo>
[Cyrill Gorcunov - Thu, Oct 22, 2009 at 05:55:57PM +0400]
...
|
| 2) All handlers set *len to some size explicitly so we may
| introduce set_sockaddr_size() helper like
|
| #define set_sockaddr_size(ptr, size) \
| do { \
| build_sockaddr_check(size); \
| *ptr = size; \
| } while (0)
|
| Or you meant something completely different?
|
| -- Cyrill
Or say it could be something like that
#define __sockaddr(type, src) \
({ build_sockaddr_check(sizeof(type)); (type *) src; })
and say in function af_inet.c:inet_getname instead of
struct sockaddr_in *sin = (struct sockaddr_in *)uaddr;
we may write like
struct sockaddr_in *sin = __sockaddr(struct sockaddr_in, uaddr);
which would check the size.
-- Cyrill
next prev parent reply other threads:[~2009-10-23 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 17:07 [RFC] net,socket: introduce build_sockaddr_check helper to catch overflow at build time Cyrill Gorcunov
2009-10-22 11:49 ` David Miller
2009-10-22 13:55 ` Cyrill Gorcunov
2009-10-23 21:43 ` Cyrill Gorcunov [this message]
2009-10-24 13:12 ` David Miller
2009-10-24 16:32 ` Cyrill Gorcunov
2009-10-29 10:00 ` David Miller
2009-10-29 14:50 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023214306.GA30616@lenovo \
--to=gorcunov@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).