From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: figo1802@gmail.com, dsilvers@simtec.co.uk,
netdev@vger.kernel.org, vince@simtec.co.uk, ben@simtec.co.uk
Subject: Re: [PATCH]NET/KS8695: add support NAPI for Rx
Date: Mon, 26 Oct 2009 15:43:09 -0700 (PDT) [thread overview]
Message-ID: <20091026.154309.165520821.davem@davemloft.net> (raw)
In-Reply-To: <1256575746.2783.37.camel@achroite>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 26 Oct 2009 16:49:06 +0000
>> @@ -152,6 +156,10 @@ struct ks8695_priv {
>> enum ks8695_dtype dtype;
>> void __iomem *io_regs;
>>
>> + #ifdef KS8695NET_NAPI
>> + struct napi_struct napi;
>> + #endif
>> +
>
> NAPI is well-established and there should be no need to make it
> optional. So far as I'm aware, all other drivers that had it as an
> option now use it unconditionally.
I absolutely refuse to apply this patch with the CPP conditional
present, if you convert to NAPI make it unconditional.
prev parent reply other threads:[~2009-10-26 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:00 [PATCH]NET/KS8695: add support NAPI for Rx Figo.zhang
2009-10-26 16:27 ` Daniel Silverstone
2009-10-26 16:49 ` Ben Hutchings
2009-10-26 22:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026.154309.165520821.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@simtec.co.uk \
--cc=bhutchings@solarflare.com \
--cc=dsilvers@simtec.co.uk \
--cc=figo1802@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vince@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).